On Wed, 2 Jun 2010 07:45:07 -0500 "Arce, Abraham" <x0066660@xxxxxx> wrote: > I'll remove length variable and keep snprintf, below oh_name -> kbd is used again, this will keep name defined in one single place > > WARN(IS_ERR(od), "Could not build omap_device for %s %s\n", > name, oh_name); In this case, why not: char *oh_name = "kbd"; There's really no point in using snprintf() for statically-defined strings. Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html