Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- Original Message ----- From: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>
To: "Jonathan Cameron" <kernel@xxxxxxxxxxxxxxxxxxxxx>
Cc: "Hemanth V" <hemanthv@xxxxxx>; <linux-kernel@xxxxxxxxxxxxxxx>; <linux-omap@xxxxxxxxxxxxxxx>; "Daniel Mack" <daniel@xxxxxxxx>; "Jonathan Cameron" <jic23@xxxxxxxxx>; "Wolfram Sang" <w.sang@xxxxxxxxxxxxxx>
Sent: Wednesday, June 02, 2010 2:24 AM
Subject: Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver


On Tue, 01 Jun 2010 21:39:10 +0100
Jonathan Cameron <kernel@xxxxxxxxxxxxxxxxxxxxx> wrote:

>
> It would be most useful if the changelog were to fully describe the
> proposed kernel<->userspace interface.  That's the most important part
> of the driver, because it's the only part we can never change.
>
> There is a desultory effort to maintain sysfs API descriptions under
> Documentation/ABI/.  I'd have thought that it would be appropriate to
> document this driver's ABI in there.
Agreed, but we get back to the debate of what we should standardise on.

I'd suggest standardising on one of the existing drivers.  That way we
have two compliant drivers and only need to change (n-2) others.  If we
pick some new standard then we need to change (n) drivers.


Currently this driver follows the same sysfs convention as supported
by isl29003.c in drivers/misc.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux