On 06/01/10 21:27, Daniel Mack wrote: > On Tue, Jun 01, 2010 at 01:12:44PM -0700, Andrew Morton wrote: >> On Mon, 24 May 2010 16:34:25 +0530 (IST) >> "Hemanth V" <hemanthv@xxxxxx> wrote: >> >>> This patch adds support for ROHM BH1780GLI Ambient light sensor. >>> >>> BH1780 supports I2C interface. Driver supports read/update of power state and >>> read of lux value (through SYSFS). Writing value 3 to power_state enables the >>> sensor and current lux value could be read. >> >> There are at least two other ambient light sensor drivers: >> drivers/misc/isl29003.c and drivers/misc/tsl2550.c. >> >> Is there any standardisation of the ABIs whcih these drivers offer? If >> so, does this new driver comply with that? > > Jonathan proposed the ALS framework for these type of devices, but it > was rejected (don't know about the reasons, I didn't follow the > discussions). Ah the wonder of emails crossing ;) For the interested... http://lkml.org/lkml/2010/3/1/367 (the main objections are Linus' email) > The new idea is to put such drivers in the industrial IO > subsystem, but I don't know how mature that approach is currently. We haven't lifted any that didn't start there as moving things into staging due to a dependency being there seemed a controversial thing to do. > > For the time being, these drivers cook up whatever sysfs interface they > like, and their userspace ABIs are not standardized, unfortunately. > >> It would be most useful if the changelog were to fully describe the >> proposed kernel<->userspace interface. That's the most important part >> of the driver, because it's the only part we can never change. >> >> There is a desultory effort to maintain sysfs API descriptions under >> Documentation/ABI/. I'd have thought that it would be appropriate to >> document this driver's ABI in there. > > FWIW, I put some documentation about the isl29003 to > Documentation/misc-devices when I wrote the driver. > > Daniel > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
