Hi Tony, > Please test this with omap3_defconfig too, and make sure it does not break > things for omap2 and omap3. Tested, no problems... > > +int omap4_init_kp(struct omap4_keypad_platform_data *kp) > > +{ > > + struct omap_hwmod *oh; > > + struct omap_device *od; > > + struct omap4_keypad_platform_data *pdata; > > + > > + unsigned int length = 0, id = 0; > > + int hw_mod_name_len = 16; > > + char oh_name[hw_mod_name_len]; > > + char *name = "omap4-keypad"; > > if (!cpu_is_omap44xx()) > return -ENODEV; I am using #ifdef CONFIG_ARCH_OMAP4 for this portion of code, what you are suggesting is to check at runtime? Best Regards Abraham -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html