* Thara Gopinath <thara@xxxxxx> [100529 17:31]: > This patch series converts the OMAP Dual Mode Timer into a > platform driver. This involves using of hwmod structures and > omap_device layer for OMAP2/3/4 dmtimers and generic > linux platform device layer for OMAP1. > > As a result of this patch series the dmtimer platform driver > resides in arch/arm/plat-omap directory and arch specific > implementations and device registerations reside in > arch/arm/mach-omap1 and arch/arm/mach-omap2 for OMAP1 > and OMAP2 PLUS respectively. > > This patch series has been compile tested for OMAP1 using > omap_1610_h2_defconfig, compile tested for OMAP2 using > omap3_defconfig and boot and sanity tested for OMAP3/OMAP4 > again using omap3_defconfig. Boot testing has been done > on OMAP3430 SDP and OMAP4430 SDP boards. All testing has > been done on origin/origin/pm-wip/hwmods-omap4 branch off > Kevin Hilman's tree as these patches have dependencies on > runtime pm API's and OMAP4 autogenerated hwmod data base. > > It would be great if somebody could test these patches on OMAP1 > and OMAP2 platforms. Looks good, but the problem I see with this series is that it's not an incremental set of patches where each patch can be verified to compile and work for all the omaps. Please restructure your series so each patch keeps working and we end up with the actual timer code under plat-omap you should be able to add all the hwmod and platform data, then add a patch that changes the timer code to use the platform data as the last patch. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
