Re: [RFC] [PATCH v3 2/4] OMAP4: Keyboard device registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 31, 2010 at 11:44:52PM +0200, ext Arce, Abraham wrote:
+	pdata = kzalloc(sizeof(struct omap4_keypad_platform_data), GFP_KERNEL);

you will never free this.

[..]

+	pdata->device_enable = omap_device_enable;

this is undefined at least here or previous patch.

+	pdata->device_idle = omap_device_idle;

same for this

+	pdata->device_shutdown = omap_device_shutdown;

and this.

--
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux