Govindraj <govindraj.ti@xxxxxxxxx> writes: > On Fri, May 28, 2010 at 2:35 AM, Kevin Hilman > <khilman@xxxxxxxxxxxxxxxxxxx> wrote: >> Hi Govindraj, >> >> "Govindraj.R" <govindraj.raja@xxxxxx> writes: >> >>> Patch series is based on remotes/origin/pm-wip/govindraj >>> branch from Kevin's PM tree. >>> >>> Patches are tested with 3430SDP. >>> Have updated 2420/2430 hwmod data files >>> it would be great if some one can test the same. >> >> OK, I've updated pm-wip/uart to include most of this series as well as >> some of the other fixes I posted yesterday to get things working on >> OMAP2. >> >>> Govindraj.R (6): >>> Serial: Clean up set_uart_globals. >>> Serial: Add UART4 hwmod data. >>> Serial: Modify OMAP3 hwmod data file with uart data. >>> Serial: Add UART hwmod data for 2420. >>> Serial: Add UART hwmod data for 2430. >>> Serial: Update UART HWMOD layer. >> >> I've kept patch 1 as is, but changed the subject slightly. >> >> Patches 2, 4 and 5 I've folded into the patch that added hwmod data >> for OMAP3. >> >> Patch 6 I folded into the initial UART conversion patch and also >> changed the authorship for that patch to you, since you've done most >> of that work. >> > > Thanks. Looks great now. > >> Patch 3, I've dropped as that shouldn't be needed after you switch >> to platform_get_resource_byname(). >> > > One comment here, > In that patch other than swapping rx and tx fields. > I had modified name field from uart*_hwmod to uart* > > - .name = "uart[1-3]_hwmod", > + .name = "uart[1-3]", > > I think this might be necessary. > To be in sync with auto generated data file. > > I think it can be incorporated with, > > OMAP2/3: UART: add omap_hwmod data for UARTs 1-4 OK, I will fold the "_hwmod" removal part of the patch into the hwmod data patch. >> Please update your omap-serial driver on top of the new pm-wip/uart >> branch and then we'll be basically ready for upstream. >> > > Sure and here is the update: > > http://marc.info/?l=linux-serial&m=127504585628001&w=2 Looks good to me. > Meanwhile I took wip-uart patches to pm branch and tested > enabling sleep_while_idle and enable_off_mode > on 3430/3630SDP with omap3_pm_defconfig. > Things worked fine with ret/off count getting incremented. Great, so this series + omap-serial is now working OMAP2420, 3430 and 3630. Nice. One other missing piece is that I need a refresh of this patch: [pm-wip/uart][PATCH] Serial: Avoid using hwmod lookup using name string against the current pm-wip/uart branch, and I will fold that into the UART hwmod conversion patch. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
