Hi Dmitry, > On Tue, May 18, 2010 at 06:13:48PM -0500, Arce, Abraham wrote: > > Hi, > > > > Here you have the list of changes done so far for OMAP4 Keyboard > > Controller Support v2. I'll appreciate if someone else has more comments > > to share. > > > > I finally had a chance to review the patches and I do not think that we > shoudl be adding new hooks, especially omap-specific platform methods, > into matrix_keypad_platform_data structure. Also, the structre does not > really match the device since it does nto use GPIOs. Why don't we > define a driver-specific platform structure based on matrix_keypad_data > and use it instead? Agree, looks clean now... > > Please try the patch below and let me know if it works for you. Yes, it works... I am putting it in a TI internal tree... > Btw, you should not be allocating platform data in the platform code - > it meant to be statically allocated and preferrably constant. I'll take a look at this... > + > +#include <plat/omap4_keypad.h> One fix to your patch... #include <plat/omap4-keypad.h> [snip] Best Regards Abraham -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
