From: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> Subject: Re: [PATCH v2t2 00/17] omap: mailbox: Date: Sat, 22 May 2010 08:14:15 +0300 (EEST) > From: ext Felipe Contreras <felipe.contreras@xxxxxxxxx> > Subject: Re: [PATCH v2t2 00/17] omap: mailbox: > Date: Sat, 22 May 2010 01:34:52 +0200 > >> On Sat, May 22, 2010 at 1:15 AM, Russell King - ARM Linux >> <linux@xxxxxxxxxxxxxxxx> wrote: >>> On Sat, May 22, 2010 at 01:09:12AM +0300, Felipe Contreras wrote: >>>> On Sat, May 22, 2010 at 12:57 AM, Russell King - ARM Linux >>>> <linux@xxxxxxxxxxxxxxxx> wrote: >>>> > The only reason 3 would be loaded due to that dependency is if 2 were >>>> > being modprobed, which means it's going to be inserted after 3 anyway. >>>> > >>>> > I don't see anything else in 3 which would trigger it to be loaded. >>>> > >>>> > The "platform:omap2-mailbox" module alias of 2 should result in 2 >>>> > being modprobed, >>>> >>>> I see, at initialization? >>> >>> That's the theory - and it should be that same mechanism which allows >>> things like already plugged in PCMCIA and the like cards to be properly >>> dealt with at boot time. >>> >>>> > causing 3 to be loaded to satisfy the dependency. >>>> > As already pointed out, this should happen as a result of udev or >>>> > (older) hotplug initialization. >>>> >>>> Well, in the minimal system I have in my beagleboard it doesn't >>>> happen. I load bridgedriver, which loads mailbox, but fails >>>> immediately because mailbox_mach is not there. >>> >>> I assume that having the MMC host driver built in, but the MMC block >>> driver as a module also doesn't work on your setup? >> >> I wouldn't know because my file-system is on the MMC. > > I guess that your other platform drivers wouldn't work as dynamic module. > >>> I don't see this as something that should be worked around in the >>> kernel by making things non-modular - I view the missing userspace >>> functionality causing the problem. >> >> First of all, most of the cleanups are independent of the built-in >> option, although that was my motivation, the patches are good by > > Your cleanup patches are ok. > >> themselves: there's no need to export >> omap_mbox_register()/_unregister() unnecessarily when the platform >> data can be used, right? > > This is not the point. > >> Now, regarding the built-in mode; for the iommu case you said it >> should be built-in: >> http://article.gmane.org/gmane.linux.ports.arm.kernel/58555 > > Right. > >> Apparently it's not, so it's not clear to me how omap3-iommu would be >> loaded since there's no "platform:" alias. > > This alias is only necessary for platform drivers. > >> Moreover, Tony says that anything that registers platform devices >> should be built-in, but omap3-iommu does register devices and is not >> built-in. > > It seems that this makes you confused. It should have been > build-in;). This is going to be integrated into omap hwmod framework > soon. For built-in part, it could be something like: >From a09c2040e083f23a43232f97cb29b9aefc9c0d11 Mon Sep 17 00:00:00 2001 From: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> Date: Mon, 24 May 2010 09:35:11 +0300 Subject: [PATCH 1/1] omap iommu: Make omap-iommu.o built-in This is a platform device registration. Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@xxxxxxxxx> --- arch/arm/mach-omap2/Makefile | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 7d2cf0f..4d754f6 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -89,7 +89,10 @@ obj-$(CONFIG_OMAP3_EMU) += emu.o obj-$(CONFIG_OMAP_MBOX_FWK) += mailbox_mach.o mailbox_mach-objs := mailbox.o -obj-$(CONFIG_OMAP_IOMMU) := iommu2.o omap-iommu.o +obj-$(CONFIG_OMAP_IOMMU) := iommu2.o + +iommu-$(CONFIG_OMAP_IOMMU) := omap-iommu.o +obj-y += $(iommu-m) $(iommu-y) i2c-omap-$(CONFIG_I2C_OMAP) := i2c.o obj-y += $(i2c-omap-m) $(i2c-omap-y) -- 1.7.1.rc1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
