If "disable" means cutting off the clock of the timer, then no. The clock for the timer is needed so DSP can clear the timer IRQ status register. If it is to stop the timer from counting, then it is fine. -----Original Message----- From: Jansson, Cris Sent: Monday, May 17, 2010 4:53 PM To: Felipe Contreras Cc: Guzman Lugo, Fernando; linux-omap; Liu, Stanley; Ramirez Luna, Omar Subject: RE: [PATCH 02/14] dspbridge: deh: trivial cleanups The safe thing to do is disable the timer after the DSP has completed the dump. During the dump processing, the DSP will clear the timer interrupt. I don't know what would happen if the timer were disabled prior to that. Best Regards, Cris -----Original Message----- From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] Sent: Monday, May 17, 2010 4:14 PM To: Jansson, Cris Cc: Guzman Lugo, Fernando; linux-omap; Liu, Stanley; Ramirez Luna, Omar Subject: Re: [PATCH 02/14] dspbridge: deh: trivial cleanups Hi Cris, On Mon, May 17, 2010 at 10:39 PM, Jansson, Cris <cjansson@xxxxxx> wrote: > Thanks for forwarding the thread. > > In wait_for_timer(), should return be used inside the loop? It will result in omap_dm_timer_disable(timer) not being called. I believe it should be called in all outcomes. Yes, that's a mistake I already acknowledged. The question is: can we disable the timer _before_ the DSP has finished dumping the stack? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
