Tomi, Thanks for your comments. We will submit the next version after incorporating these comments. Thanks and regards, Mukund > -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Friday, May 14, 2010 12:36 PM > To: Mittal, Mukund > Cc: Tony Lindgren; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: Patches for enabling display on Zoom2/3 & 3630 SDP > > Hi, > > On Mon, 2010-05-10 at 08:41 +0200, ext Mittal, Mukund wrote: > > Tomi, > > Would you please check if there are no further comments and can you > > please pull the following patches in? > > > > https://patchwork.kernel.org/patch/95067/ > > https://patchwork.kernel.org/patch/95068/ > > https://patchwork.kernel.org/patch/94937/ > > https://patchwork.kernel.org/patch/94934/ > > https://patchwork.kernel.org/patch/94893/ > > > This one is already applied: > OMAP:DSS: Add missing line for update bg color > > This patch affects also 3630SDP, should be mentioned in patch title. And > I think the title should not be "OMAP: DSS", as it's not about DSS but > the board files. It should be something like OMAP3630SDP: or similar. > OMAP: DSS: Add display board file for zoom boards > > Same comment as above: > OMAP: DSS: Enable display on ZOOM2/3 & 3630SDP > > TRM speaks of pre-multiplied alpha, as does your patch title. But in the > code your variables are pre-alpha multiplied: > OMAP3630:DSS2:Enable Pre-Multiplied Alpha Support > > For this one I have already sent comments, they have not been answered. > There were some problems with emails to linux-omap at that time, so I've > also attached the email. Also, this patch should go in before the board > file patches above, so put them into same patch set with this one before > the board file changes: > OMAP: DSS: Add NEC NL8048HL11-01B display panel > > Also, many of the patch comments contained typos. Could you check them > also? > > Tomi ��.n��������+%������w��{.n�����{�������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
