> -----Original Message----- > From: Koen Kooi [mailto:koen@xxxxxxxxxxxxxxxxxxxxx] > Sent: Thursday, May 13, 2010 9:30 PM > To: Guruswamy, Senthilvadivu > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-fbdev@xxxxxxxxxxxxxxx; > tony@xxxxxxxxxxx; tomi.valkeinen@xxxxxxxxx; Hiremath, Vaibhav > Subject: Re: [PATCH v2 1/2] DSS2: Allow FB_OMAP2 to build without VRFB > > > Op 13 mei 2010, om 17:20 heeft Senthilvadivu Guruswamy het > volgende geschreven: > > > FB_OMAP2 can work without VRFB, but currently does not > build. Fix this. > > > > Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx> > > --- > > arch/arm/plat-omap/include/plat/vrfb.h | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/plat-omap/include/plat/vrfb.h > b/arch/arm/plat-omap/include/plat/vrfb.h > > index d8a03ce..3792bde 100644 > > --- a/arch/arm/plat-omap/include/plat/vrfb.h > > +++ b/arch/arm/plat-omap/include/plat/vrfb.h > > @@ -35,6 +35,7 @@ struct vrfb { > > bool yuv_mode; > > }; > > > > +#ifdef CONFIG_OMAP2_VRFB > > That is still a compiletime option, not a runtime check. You > need something like if(is_omap3()), not #ifdef > [Senthil] Runtime check for calling VRFB functions are already taken care in FB driver omapfb-main.c with "if(rotation.type == VRFB). This compile time option is only for omap_4430sdp_defconfig to build, where sdrc functions are called from VRFB.c. Sdrc.c is not included in omap_4430sdp_defconfig build. > regards, > > Koen-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
