Hi,
>-----Original Message-----
>From: Kanigeri, Hari
>Sent: Thursday, May 13, 2010 10:55 AM
>To: Ramos Falcon, Ernesto; linux-omap@xxxxxxxxxxxxxxx
>Cc: Ameya Palande; Contreras Felipe (Nokia-D/Helsinki)
>Subject: RE: [PATCHv2] DSPBRIDGE: Include missing info in MMU Fault
>debugging trace
>
>Ernesto
>
>> @@ -2136,6 +2138,7 @@ dsp_status dump_dsp_stack(struct bridge_dev_context
>> *bridge_context)
>> total_size = MAX_MMU_DBGBUFF;
>>
>> buffer = kzalloc(total_size, GFP_ATOMIC);
>> + buffer_beg = buffer;
>> buffer_end = buffer + total_size / 4;
>>
>> if (!buffer) {
>
>-- Shouldn't this check be present before the above 2 statements ?
>
I think in this case does not affect those two assignments could be avoid it, so OK.
>> for (i = 0; buffer < buffer_end; i++, buffer++) {
>> if ((*buffer > 0x01000000) && (node_find_addr(node_mgr,
>
>-- Is 0x01000000 MAX_MMU_DBGBUFF ?
OK, I'll change.
>
>Thank you,
>Best regards,
>Hari
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
