Koen Kooi had written, on 05/13/2010 11:00 AM, the following:
Op 13 mei 2010, om 17:20 heeft Senthilvadivu Guruswamy het volgende geschreven:
FB_OMAP2 can work without VRFB, but currently does not build. Fix this.
Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx>
---
arch/arm/plat-omap/include/plat/vrfb.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/vrfb.h b/arch/arm/plat-omap/include/plat/vrfb.h
index d8a03ce..3792bde 100644
--- a/arch/arm/plat-omap/include/plat/vrfb.h
+++ b/arch/arm/plat-omap/include/plat/vrfb.h
@@ -35,6 +35,7 @@ struct vrfb {
bool yuv_mode;
};
+#ifdef CONFIG_OMAP2_VRFB
That is still a compiletime option, not a runtime check. You need something like if(is_omap3()), not #ifdef
having VRFB or tiler is a SOC feature - ideal detection should be in
id.c using the FEATURES framework.
and the actual rotation handling should be handled with function
pointers to use VRFB apis OR use tiler APIs (once it is available) to
runtime use the right rotation/other features functions runtime..
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
