Re: [PATCH 4/5] musb: use system DMA for unaligned buffers on RTL >= 1.8

[Sergei Shtylyov <sshtylyov@xxxxxxxxxx>]

Hello.

Gupta, Ajay Kumar wrote:

> Hi,
>   
> > >  	if (channel->status == MUSB_DMA_STATUS_BUSY) {
> > >  		if (musb_channel->transmit) {
> > > +			if (musb_channel->sysdma_channel != -1)
> > > +				omap_stop_dma(musb_channel->sysdma_channel);
> > > +
> > >
> > >       
> >    Have you thought about e.g. Blackfin? How this is going to compile
> > there, without omap_*() functions even existing? Or did you think that
> > OMAP is the only user of this driver?
> >     
> Thanks for pointing this. It would require adding wrapper functions for
> Blckfin's.
>   

  Better wrap your stuff into #ifdef OMAP, I think...

> -Ajay
>   
WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html