Re: [PATCH 2/6] OMAP3: GPIO: Only enable WAKEUPEN for edge detection GPIOs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-cqwang address which is bouncing

Tony Lindgren <tony@xxxxxxxxxxx> writes:

> * Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [100511 07:22]:
>> Tony Lindgren <tony@xxxxxxxxxxx> writes:
>> 
>> > * Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [100503 16:28]:
>> >> From: Chunqiu Wang <cqwang@xxxxxxxxxxxx>
>> >> 
>> >> According to the GPIO 'Wakeup and Interrupt' section of the TRM[1],
>> >> wake-up requests can only be generated on edge transitions.
>> >> 
>> >> Also for OMAP3, only edge GPIOs may lose interrupts when PER enters
>> >> RET/OFF state, this is addressed by gpio prepare|resume idle functions
>> >
>> > There's a generic solution to this problem. The solution is to temporarily
>> > set the level GPIO pins into edge for the duration of idle. Then
>> > they need to be set back to level after the system is woken up.
>> 
>> Sure, but that doesn't change the need for this patch which is
>> a correctness fix.
>> 
>> Adding wakeup support for level GPIOs would be a separate fix.
>
> OK, let's plan on merging these then. Want me to pick these,
> or pull from some branch?

You can pull from the gpio-2.6.35 branch in my tree.

> Looks like they also need to be posted to LAKML too, and we
> should get them into linux-omap master for some testing.

Oops, meant to cc l-a-k.  Will repost with l-a-k in Cc.

Kevin

> Looks like these should not cause much of merge issues with
> the gpio platform init patches. It would be nice to get those
> merged too if possible.
>
> Regards,
>
> Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux