Re: [PATCH 1/1] omap-hsmmc.c: re-organize dma line population

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Madhvapathi Sriram <sriram.m@xxxxxx> [100511 02:26]:
> @@ -255,6 +256,52 @@ int __init omap_mmc_add(const char *name, int id, unsigned long base,
>  	res[0].flags = IORESOURCE_MEM;
>  	res[1].start = res[1].end = irq;
>  	res[1].flags = IORESOURCE_IRQ;
> +	/* Populate DMA lines based on the instance used. Rx first,Tx next*/
> +	switch (id) {
> +	case 0:
> +		res[2].start = OMAP24XX_DMA_MMC1_RX;
> +		res[2].end = OMAP24XX_DMA_MMC1_RX;
> +		res[2].flags = IORESOURCE_DMA;
> +		res[3].start = OMAP24XX_DMA_MMC1_TX;
> +		res[3].end = OMAP24XX_DMA_MMC1_TX;
> +		res[3].flags = IORESOURCE_DMA;
> +		break;
> +	case 1:
> +		res[2].start = OMAP24XX_DMA_MMC2_RX;
> +		res[2].end = OMAP24XX_DMA_MMC2_RX;
> +		res[2].flags = IORESOURCE_DMA;
> +		res[3].start = OMAP24XX_DMA_MMC2_TX;
> +		res[3].end = OMAP24XX_DMA_MMC2_TX;
> +		res[3].flags = IORESOURCE_DMA;
> +		break;
> +	case 2:
> +		res[2].start = OMAP34XX_DMA_MMC3_RX;
> +		res[2].end = OMAP34XX_DMA_MMC3_RX;
> +		res[2].flags = IORESOURCE_DMA;
> +		res[3].start = OMAP34XX_DMA_MMC3_TX;
> +		res[3].end = OMAP34XX_DMA_MMC3_TX;
> +		res[3].flags = IORESOURCE_DMA;
> +		break;
> +	case 3:
> +		res[2].start = OMAP44XX_DMA_MMC4_RX;
> +		res[2].end = OMAP44XX_DMA_MMC4_RX;
> +		res[2].flags = IORESOURCE_DMA;
> +		res[3].start = OMAP44XX_DMA_MMC4_TX;
> +		res[3].end = OMAP44XX_DMA_MMC4_TX;
> +		res[3].flags = IORESOURCE_DMA;
> +		break;
> +	case 4:
> +		res[2].start = OMAP44XX_DMA_MMC5_RX;
> +		res[2].end = OMAP44XX_DMA_MMC5_RX;
> +		res[2].flags = IORESOURCE_DMA;
> +		res[3].start = OMAP44XX_DMA_MMC5_TX;
> +		res[3].end = OMAP44XX_DMA_MMC5_TX;
> +		res[3].flags = IORESOURCE_DMA;
> +		break;
> +	default:
> +		ret = -ENODEV;
> +		goto fail;
> +	}

To me it seems like this should go into mach-omap2/hsmmc.c instead
of plat-omap/devices.c.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux