Manjunatha GK <manjugk@xxxxxx> writes:
> The SGX powervr_device is registered with it's platform specific
> data to provide information about setting constraint through
> omap_pm_set_min_bus_tput.
>
> Signed-off-by: Preshit Agarwal <preshit.agarwal@xxxxxx>
> Signed-off-by: Manjunatha GK <manjugk@xxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
> Cc: Mike Turquette <mturquette@xxxxxx>
> Cc: Hemanth V <hemanthv@xxxxxx>
> ---
> arch/arm/mach-omap2/devices.c | 26 ++++++++++++++++++++++-
> arch/arm/mach-omap2/include/mach/omap_sgxdef.h | 11 ++++++++++
> 2 files changed, 35 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm/mach-omap2/include/mach/omap_sgxdef.h
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index 20fa76e..aabbf7b 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -26,7 +26,7 @@
> #include <plat/mux.h>
> #include <mach/gpio.h>
> #include <plat/mmc.h>
> -
> +#include <mach/omap_sgxdef.h>
> #include "mux.h"
>
> #if defined(CONFIG_VIDEO_OMAP2) || defined(CONFIG_VIDEO_OMAP2_MODULE)
> @@ -791,6 +791,28 @@ static inline void omap_hdq_init(void)
> static inline void omap_hdq_init(void) {}
> #endif
>
> +struct sgx_platform_data omap_sgx_data = {
> +#ifdef CONFIG_PM
> + .set_min_bus_tput = omap_pm_set_min_bus_tput,
> +#else
> + .set_min_bus_tput = NULL,
> +#endif
Please explain why this should be dependent on CONFIG_PM?
I suspect you should be making these kinds of decisions in the driver
itself, not in device init.
> +};
> +
> +static struct platform_device powervr_device = {
> + .name = "pvrsrvkm",
> + .id = -1,
> + .dev = {
> + .platform_data = &omap_sgx_data,
> + }
> +};
> +
> +static void omap_init_sgx(void)
> +{
> + (void) platform_device_register(&powervr_device);
> +}
> +
> +
> /*-------------------------------------------------------------------------*/
>
> static int __init omap2_init_devices(void)
> @@ -805,7 +827,7 @@ static int __init omap2_init_devices(void)
> omap_hdq_init();
> omap_init_sti();
> omap_init_sha1_md5();
> -
> + omap_init_sgx();
> return 0;
> }
> arch_initcall(omap2_init_devices);
> diff --git a/arch/arm/mach-omap2/include/mach/omap_sgxdef.h b/arch/arm/mach-omap2/include/mach/omap_sgxdef.h
> new file mode 100644
> index 0000000..5d90a6a
> --- /dev/null
> +++ b/arch/arm/mach-omap2/include/mach/omap_sgxdef.h
> @@ -0,0 +1,11 @@
> +#ifndef OMAP_SGXDEF_H
> +#define OMAP_SGXDEF_H
> +
> +#include <plat/omap-pm.h>
> +
> +struct sgx_platform_data {
> + void(*set_min_bus_tput)(struct device *dev, u8 agent_id,
need a space after 'void' and before '('
> + unsigned long r);
minor nit: you could drop a tab of 3 for nicer looking alignment
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
