Hello again,
On Mon, May 10, 2010 at 01:13:00PM +0200, ext Paul Mundt wrote:
> On Mon, May 10, 2010 at 01:37:34PM +0300, Eduardo Valentin wrote:
> > + */
> > +#include <linux/fs.h>
> > +#include <linux/init.h>
> > +#include <linux/proc_fs.h>
> > +#include <linux/seq_file.h>
> > +
> > +extern const struct seq_operations socinfo_op;
>
> This doesn't look promising..
>
> > +static int socinfo_open(struct inode *inode, struct file *file)
> > +{
> > + return seq_open(file, &socinfo_op);
> > +}
> > +
> If you use single_open() ..
>
> > +static const struct file_operations proc_socinfo_operations = {
> > + .open = socinfo_open,
> > + .read = seq_read,
> > + .llseek = seq_lseek,
> > + .release = seq_release,
> > +};
> > +
> .. and single_release(), then none of the seq_operations are necessary.
>
> > +static int __init proc_socinfo_init(void)
> > +{
> > + proc_create("socinfo", 0, NULL, &proc_socinfo_operations);
> > + return 0;
> > +}
> > +module_init(proc_socinfo_init);
>
> proc_create() can fail, so some error handling here would be nice.
>
> On Mon, May 10, 2010 at 01:37:35PM +0300, Eduardo Valentin wrote:
> > +static int c_show(struct seq_file *m, void *v)
> > +{
> > + seq_printf(m, "SoC\t: %s\n", socinfo);
> > +
> > + return 0;
> > +}
> > +
> > +static void *c_start(struct seq_file *m, loff_t *pos)
> > +{
> > + return *pos < 1 ? (void *)1 : NULL;
> > +}
> > +
> > +static void *c_next(struct seq_file *m, void *v, loff_t *pos)
> > +{
> > + ++*pos;
> > + return NULL;
> > +}
> > +
> > +static void c_stop(struct seq_file *m, void *v)
> > +{
> > +}
> > +
> > +const struct seq_operations socinfo_op = {
> > + .start = c_start,
> > + .next = c_next,
> > + .stop = c_stop,
> > + .show = c_show
> > +};
>
> You'll still need the show function, but all of the rest of this is just
> duplicating what single_open() already does. If the socinfo string is
> static you may also want to rework this a bit so you can just stash the
> string in the proc_dir_entry private data. Combine this with something
> like kstrdup() and you'll save yourself a bit of stack while you're at
> it.
While still here, about cleaning this, so, let me see if I got your point.
Basically, the file under fs/proc/socinfo.c whould do the thing with single_open &
single_release, as you stated. But then there is the .show and its data.
One idea would then be to have a function:
int register_socinfo_show(int (*show)(struct seq_file *, void *), void *data);
Which would be exported to other parts of the kernel (something placed under
include/linux/socinfo.h for instance). Then the soc core code
(like arch/arm/mach-omap[1,2]) would then register its local show function and pass its data.
This way I think we can avoid the exports inside .c files (as in this patch)
and also pass the static char * needed during the show.
What do you think?
BR,
--
Eduardo Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
