On 05/10/2010 03:26 AM, Guruswamy, Senthilvadivu wrote:
Tiler support is not yet in OMAP builds. So multi-omap build will NOT break, but would exclude VRFB feature in the build.
in which case, is'nt this patch redundant :) ?
joking apart, would'nt a set of function pointers be better - the
function pointers could be runtime initialized. the rotational functions
for Tiler OR vrfb could be used?
-----Original Message-----
From: Koen Kooi [mailto:koen@xxxxxxxxxxxxxxxxxxxxx]
Sent: Monday, May 10, 2010 1:33 PM
To: Guruswamy, Senthilvadivu
Cc: linux-omap@xxxxxxxxxxxxxxx;
linux-fbdev-devel@xxxxxxxxxxxxxxxxxxxxx; tony@xxxxxxxxxxx;
tomi.valkeinen@xxxxxxxxx; Hiremath, Vaibhav
Subject: Re: [PATCH] DSS2 Include VRFB into omap2-3build only
Op 10 mei 2010, om 10:01 heeft Guruswamy, Senthilvadivu het
volgende geschreven:
Building a multi-omap kernel is not impacted as long as the
display is not choosen in the build. Usually display is
chosen from the board file.
So you are saying it *IS* broken when wanting vrfb on omap3
and tiler on omap4, right?
-----Original Message-----
From: Koen Kooi [mailto:koen@xxxxxxxxxxxxxxxxxxxxx]
Sent: Monday, May 10, 2010 1:10 PM
To: Guruswamy, Senthilvadivu
Cc: linux-omap@xxxxxxxxxxxxxxx;
linux-fbdev-devel@xxxxxxxxxxxxxxxxxxxxx; tony@xxxxxxxxxxx;
tomi.valkeinen@xxxxxxxxx; Hiremath, Vaibhav
Subject: Re: [PATCH] DSS2 Include VRFB into omap2-3build only
Op 10 mei 2010, om 08:48 heeft Senthilvadivu Guruswamy het
volgende geschreven:
Exclude VRFB from OMAP4 onwards and include only for
OMAP2 and OMAP3 builds. In OMAP4 VRFB HW IP is replaced
with a new HW IP "TILER"
--- a/drivers/video/omap2/Kconfig
+++ b/drivers/video/omap2/Kconfig
@@ -3,6 +3,10 @@ config OMAP2_VRAM
config OMAP2_VRFB
bool
+ depends on FB_OMAP2&& (!ARCH_OMAP4)
+ default y if (ARCH_OMAP2 || ARCH_OMAP3)
+ help
+ OMAP VRFB buffer support is efficient for rotation
How does this work for multi-omap kernels, e.g. building a
kernel with beagle and panda support?
regards,
Koen
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
