RE: [PATCH 1/2] ARM: McBSP: Fix request for irq in OMAP4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jarkko Nikula wrote:
> On Wed, 5 May 2010 08:32:13 +0530
> "G, Manjunath Kondaiah" <manjugk@xxxxxx> wrote:
> 
>>> -		init_completion(&mcbsp->rx_irq_completion);
>>> -		err = request_irq(mcbsp->rx_irq,
>>> omap_mcbsp_rx_irq_handler,
>>> +		if (!cpu_is_omap44xx) {
>>> +			init_completion(&mcbsp->rx_irq_completion);
>>> +			err = request_irq(mcbsp->rx_irq,
>>> +					omap_mcbsp_rx_irq_handler,
>>>  					0, "McBSP", (void *)mcbsp);
>> 
>> How about using request_threaded_irq?
>> Refer to: http://lwn.net/Articles/302043/
>> 
> Threaded irq conversion would be better to handle as a separate patch
> as it does different thing than this patch.

I will redo this patch without threaded irq for now, and will do the
conversion in a later patch then.--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux