Re: [PATCH 2/2] usb: ehci-omap: fix Si version related programming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 04, 2010 at 01:15:23PM +0530, Ajay Kumar Gupta wrote:
> @@ -352,8 +352,8 @@ static int omap_start_ehc(struct ehci_hcd_omap *omap, struct usb_hcd *hcd)
>  		reg &= ~OMAP_UHH_HOSTCONFIG_P3_CONNECT_STATUS;
>  
>  	/* Bypass the TLL module for PHY mode operation */
> -	 if (omap_rev() <= OMAP3430_REV_ES2_1) {
> -		dev_dbg(omap->dev, "OMAP3 ES version <= ES2.1 \n");
> +	if (cpu_is_omap3430() && (omap_rev() <= OMAP3430_REV_ES2_1)) {
> +		dev_dbg(omap->dev, "OMAP3 ES version <= ES2.1\n");

this shouldn't be here. please pass down a flag through platform_data
for such checks.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux