<snip>
> >> + if (cpu_is_omap44xx() || cpu_is_omap3630()) {
> > Can we avoid above by passing this part of platform data??
> > devices.c
>
> I am not clear about the method. The board files export the
> omap_mmc_platform_data.
> Does it imply that all board files have to change and export
> the capability so that it can be queried ?
>
I don?t see why this capability needs to be passed from the platform data.
As this feature is dependant on omap it is okay to have a cpu check in the
driver as the patch is doing it.
> >> + host->dma_ctrl_buf = dma_alloc_coherent(NULL,
> >> + DMA_CTRL_BUF_SIZE,
> >> + &host->dma_ctrl_buf_phy,
> >> + 0);
> >> + if (host->dma_ctrl_buf != NULL)
> >> + host->dma_caps |= DMA_TYPE_SDMA_DLOAD;
> >> + }
> >> +
> >> /* Since we do only SG emulation, we can have as many segs
> >> * as we want. */
> > Not your patch but above commenting style isn't right
> OK
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
