> -----Original Message----- > From: Ville Syrjälä [mailto:ville.syrjala@xxxxxxxxx] > Sent: Tuesday, May 04, 2010 7:15 PM > To: Hiremath, Vaibhav > Cc: Valkeinen Tomi (Nokia-D/Helsinki); linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] OMAP: DSS2: GFX FIFO UNDERFLOW issue fixed > > On Tue, May 04, 2010 at 03:23:10PM +0200, ext Hiremath, Vaibhav wrote: > > <snip> > > I found the bug which is causing tearing effect, I tested it here with > both, mine and your applications and for me it is working fine. > > > > Can you please check at your end? > > (Sorry for the attachment) > > You should really avoid that. I can't quote the patch. [Hiremath, Vaibhav] I completely understand, actually the intention of this patch is to test so avoided "git send-email". > > What are those CW<->CCW swaps that you do in the patch? [Hiremath, Vaibhav] Did you observed how the rotation comes on the screen? Does it rotate the image clockwise of anti-clockwise direction? This is required to get clockwise rotation. > > Also I think the ioremap stuff is a bit broken since AFAICS it will > leave the old angle still mapped when you rotate to another angle. > [Hiremath, Vaibhav] Why do you say that? Are you referring to changing rotation from sysfs here? I hope you understand the change here, we are now mapping the write buffer to user space and overlay DMA is configured to 0 degree address map. So when you change the only rotation without writing anything to buffer (mapping is important here, since it will map newly configured rotated view) the display will stay intact. I have tested with both SYSFS and FBIO_PUTVSCREENINFO ioctl, the only difference in behavior is you have to write it buffer to see rotated image. Thanks, Vaibhav > -- > Ville Syrjälä -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
