Nishanth Menon <nm@xxxxxx> writes: > BUG_ON should not ideally contain a functional code. > Ref: http://marc.info/?l=linux-kernel&m=109391212925546&w=2 > > To do this, we change the return of omap3_pm_init_opp from > void to int and return back error value for caller to adequately > handle further decisions. to reduce code duplication, the > registration and error handling are done in loop now. > > Cc: Ambresh K <ambresh@xxxxxx> > Cc: Benoit Cousson <b-cousson@xxxxxx> > Cc: Eduardo Valentin <eduardo.valentin@xxxxxxxxx> > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > Cc: Phil Carmody <ext-phil.2.carmody@xxxxxxxxx> > Cc: Sanjeev Premi <premi@xxxxxx> > Cc: Tero Kristo <tero.kristo@xxxxxxxxx> > Cc: Thara Gopinath <thara@xxxxxx> > > Signed-off-by: Nishanth Menon <nm@xxxxxx> > --- > Ref: > v1: https://patchwork.kernel.org/patch/86793/ > v2: https://patchwork.kernel.org/patch/93701/ > v3: cosmetic changes including cleaning up the while loop for > recovery path, also fix omap3_pm_init_opp_table when CPU_FREQ > is not present in the line of rest of opp apis Thanks, applied to pm-wip-opp. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
