* Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [100420 16:01]: > Lesly A M <leslyam@xxxxxx> writes: > > > Fix for TWL5030 Silicon Errata 27 & 28: > > 27 - VDD1, VDD2, may have glitches when their output value is updated. > > 28 - VDD1 and / or VDD2 DCDC clock may stop working when internal clock > > is switched from internal to external. > > > > Workaround requires the TWL DCDCs to use HFCLKIN instead of internal oscillator. > > > > There is a chance for VDD1/VDD2 to collapse to 0 Volt, > > if we switch the TWL DCDCs to internal oscillator form HFCLKIN > > while VDD1/VDD2 is active. So during first time when we switch TWLDCDC to > > HFCLKIN, TWL watchdog timer is used to recover if the VDD1/VDD2 stop working. > > > > Using HFCLKIN for TWL DCDCs uncovers another issue when going in and > > out of OFF mode, if HFCLK is disabled in OFFMODE. So the sleep/wakeup > > sequence and setuptimes are modified to make sure the switching will > > happen only when HFCLKIN is stable. > > > > This fix is required for TWL5030 Silicon version less than or equal to ES1.1 > > Since the IDCODE register on TWL5030 Si is not updated correctly, > > version check may not be correct. So if someone want to disable the > > glitch fix changes during menuconfig, the changes are done under the macro > > CONFIG_TWL5030_GLITCH_FIX. > > > > Changes taken from Nishanth Menons gaia glitch fix patch. > > > > Signed-off-by: Lesly A M <leslyam@xxxxxx> > > Cc: Nishanth Menon <nm@xxxxxx> > > Cc: David Derrick <dderrick@xxxxxx> > > Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> > > --- > > Thanks for the much improved changelog. > > Also, this is better called an errata workaround instead of a glitch > fix. I'd rather see "glitch" here replaced by the errata numbers. > Down the road we'll be asking "which glitch?" > > As in the first review, I don't like the Kconfig option. This errata > workaround should be in common code and enabled by an optional > flag in board code. More on this below... Me neither. This needs to be set dynamically based on the twl version. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
