> -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Tuesday, April 20, 2010 8:11 PM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] OMAP:ls037v7dw01: Included slab.h file required for > kzalloc > > Hi, > > On Tue, 2010-04-20 at 11:44 +0200, ext hvaibhav@xxxxxx wrote: > > From: Vaibhav Hiremath <hvaibhav@xxxxxx> > > > > With recent kernel changes, without inclusion of slab.h > > kernel build fails with, > > > > CC drivers/video/omap2/displays/panel-sharp-ls037v7dw01.o > > drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c: In function > > 'sharp_ls_panel_probe': > > drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c:93: error: > implicit > > declaration of function 'kzalloc' > > drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c:93: warning: > > assignment makes pointer from integer without a cast > > drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c:106: error: > implicit > > declaration of function 'kfree' > > make[4]: *** [drivers/video/omap2/displays/panel-sharp-ls037v7dw01.o] > Error 1 > > make[3]: *** [drivers/video/omap2/displays] Error 2 > > make[2]: *** [drivers/video/omap2] Error 2 > > make[1]: *** [drivers/video] Error 2 > > make: *** [drivers] Error 2 > > > > > > I already added this include into the backlight patch you sent > previously. > [Hiremath, Vaibhav] Great, My daily build generated this issue and I haven't seen it neither in linux-omap/master nor in linux-omap/dss2 so created a patch. Thanks, Vaibhav > Tomi > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx> > > --- > > .../video/omap2/displays/panel-sharp-ls037v7dw01.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c > b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c > > index d84feb0..7d9eb2b 100644 > > --- a/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c > > +++ b/drivers/video/omap2/displays/panel-sharp-ls037v7dw01.c > > @@ -23,6 +23,7 @@ > > #include <linux/backlight.h> > > #include <linux/fb.h> > > #include <linux/err.h> > > +#include <linux/slab.h> > > > > #include <plat/display.h> > > > > -- > > 1.6.2.4 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
