>From e8b0597f602aa501cdda039c609a5f4fe31b3281 Mon Sep 17 00:00:00 2001 From: Ernesto Ramos <ernesto@xxxxxx> Date: Fri, 16 Apr 2010 18:40:53 -0500 Subject: [PATCH 5/5] DSPBRIDGE: Avoid errors if stream id is zero As 'zero' can be a perfectly good id, it can be picked up as a NULL from userspace, avoid issues in API and user apps if stream handle is zero. Signed-off-by: Ernesto Ramos <ernesto@xxxxxx> --- drivers/dsp/bridge/pmgr/wcd.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/dsp/bridge/pmgr/wcd.c b/drivers/dsp/bridge/pmgr/wcd.c index 9d63b1f..43e8186 100644 --- a/drivers/dsp/bridge/pmgr/wcd.c +++ b/drivers/dsp/bridge/pmgr/wcd.c @@ -1498,7 +1498,7 @@ inline void find_strm_handle(struct strm_res_object **strmres, { rcu_read_lock(); *strmres = idr_find(((struct process_context *)pr_ctxt)->strm_idp, - (int)hstream); + (int)hstream - 1); rcu_read_unlock(); return; } @@ -1713,6 +1713,8 @@ u32 strmwrap_open(union Trapped_Args *args, void *pr_ctxt) args->args_strm_open.index, &attr, &strm_res_obj, pr_ctxt); CP_TO_USR(args->args_strm_open.ph_stream, &strm_res_obj->id, status, 1); + if (DSP_SUCCEEDED(status)) + *args->args_strm_open.ph_stream += 1; return status; } -- 1.5.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html