Op 16 apr 2010, om 13:05 heeft Thomas Weber het volgende geschreven:
> Hello Koen,
> On 04/16/10 08:38, Koen Kooi wrote:
>> No more comments on this one? Can it go into Tony's tree now?
>>
>> Op 15 apr 2010, om 10:52 heeft Koen Kooi het volgende geschreven:
>>
>>> This patch adds DSS2 support to the beagleboard boardfile. DVI and TV-out are supported.
>>>
>>> Signed-off-by: Koen Kooi <koen@xxxxxxxxxxxxxxxxxxxxx>
>>> ---
>>>
>>> Changes since v1:
>>> * removed beagle_panel_enable_tv() and beagle_panel_disable_tv()
>>> Changes since v2:
>>> * changed to REGULATOR_SUPPLY(_name, _dev_name) for dss regulators
>>> Changes since v3:
>>> * really remove beagle_panel_enable_tv() and beagle_panel_disable_tv()
>>> * moved comments to this section
>>> Changes since v4:
>>> * remove trailing whitespace
>>> Changes since v5:
>>> * fix semicolon typo
>>>
>>> arch/arm/mach-omap2/board-omap3beagle.c | 102 ++++++++++++++++++++++--------
>>> 1 files changed, 75 insertions(+), 27 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
>>> index 962d377..43d3e7d 100644
>>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
>>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
>>> @@ -39,6 +39,7 @@
>>>
>>> #include <plat/board.h>
>>> #include <plat/common.h>
>>> +#include <plat/display.h>
>>> #include <plat/gpmc.h>
>>> #include <plat/nand.h>
>>> #include <plat/usb.h>
>>> @@ -106,6 +107,77 @@ static struct platform_device omap3beagle_nand_device = {
>>> .resource = &omap3beagle_nand_resource,
>>> };
>>>
>>> +/* DSS */
>>> +
>>> +static int beagle_enable_dvi(struct omap_dss_device *dssdev)
>>> +{
>>> + if (dssdev->reset_gpio != -1)
>>> + gpio_set_value(dssdev->reset_gpio, 1);
> There was already a comment about using gpio_is_valid(dssdev->reset_gpio)
Would this be acceptable:
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -111,7 +111,7 @@ static struct platform_device omap3beagle_nand_device = {
static int beagle_enable_dvi(struct omap_dss_device *dssdev)
{
- if (dssdev->reset_gpio != -1)
+ if (gpio_is_valid(dssdev->reset_gpio))
gpio_set_value(dssdev->reset_gpio, 1);
return 0;
@@ -119,7 +119,7 @@ static int beagle_enable_dvi(struct omap_dss_device *dssdev)
static void beagle_disable_dvi(struct omap_dss_device *dssdev)
{
- if (dssdev->reset_gpio != -1)
+ if (gpio_is_valid(dssdev->reset_gpio))
gpio_set_value(dssdev->reset_gpio, 0);
}
Or do I need to emit ENXIO on failure like mach-davinci/board-dm355-leopard.c is doing?
regards,
Koen--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
