Hi Janusz, On Thu, Apr 15, 2010 at 04:31:03AM +0200, Janusz Krzysztofik wrote: > + > +config SERIO_AMS_DELTA > + tristate "Amstrad Delta (E3) mailboard support" > + depends on MACH_AMS_DELTA > + default y > + select AMS_DELTA_FIQ > + select KEYBOARD_ATKBD I'd rather not select atkbd here since it is not required for this driver to work but simply adjust your defconfig. > + > + if (!(machine_is_ams_delta())) > + return -ENODEV; Extra parens. Otherwise: Acked-by: Dmitry Torokhov <dtor@xxxxxxx> I assume it is going to be merged with the rest of your patches through a tree other than linux-input. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html