> -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Monday, April 12, 2010 5:32 PM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: RE: [PATCH] OMAP: DSS2: GFX FIFO UNDERFLOW issue fixed > > On Mon, 2010-04-12 at 13:47 +0200, ext Hiremath, Vaibhav wrote: > > > -----Original Message----- > > > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > > > Sent: Thursday, April 01, 2010 7:12 PM > > > To: Hiremath, Vaibhav > > > Cc: linux-omap@xxxxxxxxxxxxxxx > > > Subject: Re: [PATCH] OMAP: DSS2: GFX FIFO UNDERFLOW issue fixed > > > > > > On Mon, 2010-03-22 at 14:09 +0100, ext hvaibhav@xxxxxx wrote: > > > > From: Vaibhav Hiremath <hvaibhav@xxxxxx> > > > > > > > > In case of 720P with 90/270 degree rotation, the system reports > > > > GFX_FIFO_UNDERFLOW error which usually happens if DSS DMA is not able > to > > > fill > > > > the FIFO as per requirement. > > > > > > > > In TRM (section 11.2.6.1.3), where is has been clearly mentioned that, > > > > > > > > "To improve the performance on 90 degree rotation, split the data > access > > > on > > > > write side and not read side." > > > > > > > > That means, read should always happen on 0 degree and write should go > to > > > > respective rotation view. > > > > > > I haven't had time to look at this patch yet. I'll try to do it next > > > week. > > [Hiremath, Vaibhav] Tomi, > > > > Have you had a chance to look at this patch/issue? > > Sorry, no I haven't. It's on my list. But did you consider my > explanation? Does your implementation support changing the rotation > dynamically? [Hiremath, Vaibhav] Yes, I have validated it here at my end for some rotation angles. Just to clarify more on this, below is the test environment - - Enable the rotation through bootargs, Bootargs: omapfb.rotate=1 omapfb.rotate_type=y vram=10M vram.fb=0:10 - Boot the system and configure the rotation using FBIOPUT_VSCREENINFO by using var.rotate field. - Normal test case which I run - Var.rotate = 0 (0 degree) Var.rotate = 1 (90 degree) Thanks, Vaibhav > > Tomi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
