Chikkature Rajashekar, Madhusudhan had written, on 04/06/2010 06:23 PM,
the following:
-----Original Message-----
From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx]
Sent: Tuesday, April 06, 2010 11:57 AM
To: ext Nishanth Menon
Cc: Balbi Felipe (Nokia-D/Helsinki); Chikkature Rajashekar, Madhusudhan;
me@xxxxxxxxxxxxxxx; 'kishore kadiyala'; 'Vimal Singh'; tony@xxxxxxxxxxx;
S, Venkatraman; linux-omap@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
Lavinen Jarkko (Nokia-D/Helsinki)
Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's
peformance.
On Tue, Apr 06, 2010 at 06:55:03PM +0200, ext Nishanth Menon wrote:
some reasons why i love switch statements ;) since I dont expect other
than precisely 4 and 8 (do we expect 5,6,7 - i might be wrong).. but if
it is so, wont the following be better?
switch (mmc_slot(host).wires)
{
case 8:
mmc->caps |= MMC_CAP_8_BIT_DATA;
/* fall thru*/
case 4:
mmc->caps |= MMC_CAP_4_BIT_DATA;
break;
default:
WARN("bad width");
}
I like that, but I remember Madhu (or someone else) saying he thinks
it's less readable this way. Go figure...
Well, I did not comment on the usage of switch here. Note we only need to
handle 8-bit and 4-bit.The board files need not setup 8-bit or 4-bit if the
configuration of that board is 1-bit. The driver will still work in 1-bit
mode which would mean there is nothing to do in default case and should not
err out.
check the attachment out.. hope that takes care of it.. just as a
reference alone ofcourse..
--
Regards,
Nishanth Menon
>From 09b55eb33749d308586c19485bf1e1723009fc9a Mon Sep 17 00:00:00 2001
From: kishore kadiyala <kishorek.kadiyala@xxxxxxxxx>
Date: Wed, 31 Mar 2010 07:03:01 +0000
Subject: [PATCH Vn] OMAP: Fix for bus width which improves SD card's peformance.
This patch improves low speeds for SD cards.
OMAP-MMC controller's can support maximum bus width of '8'.
when bus width is mentioned as "8" in controller data,the SD
stack will check whether bus width is "4" and if not it will
set bus width to "1" and there by degrading performance.
This patch fixes the issue and improves the performance of
SD cards.
Signed-off-by: Kishore Kadiyala <kishore.kadiyala@xxxxxx>
Signed-off-by: Venkatraman S <svenkatr@xxxxxx>
Acked-by: Madhusudhan Chikkature <madhu.cr@xxxxxx>
Tested-by: Jarkko Nikula <jhnikula@xxxxxxxxx>
---
NM Note:
Completely untested/unreviewed.. just holding on to
what was in https://patchwork.kernel.org/patch/89898/
with my suggested mods
drivers/mmc/host/omap_hsmmc.c | 32 +++++++++++++++++++++++++++++---
1 files changed, 29 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 83f0aff..89e26bc 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2091,10 +2091,36 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
mmc->caps |= MMC_CAP_MMC_HIGHSPEED | MMC_CAP_SD_HIGHSPEED |
MMC_CAP_WAIT_WHILE_BUSY;
- if (mmc_slot(host).wires >= 8)
+ switch(mmc_slot(host).wires) {
+ case 8:
mmc->caps |= MMC_CAP_8_BIT_DATA;
- else if (mmc_slot(host).wires >= 4)
- mmc->caps |= MMC_CAP_4_BIT_DATA;
+ /* Fall through */
+ case 4:
+ mmc->caps |= MMC_CAP_8_BIT_DATA;
+ break;
+ case 1:
+ /*
+ * I will still survive with this config.. but warn
+ * if the board file was goofed up
+ */
+ dev_warn(mmc_dev(host->mmc), "Using potentially"
+ "unoptimal 1bit config\n");
+ break;
+ default:
+ /* Completely unexpected.. dont wanna croak and die */
+ dev_crit(mmc_dev(host->mmc), "Unknown width %d"
+ "used!\n",mmc_slot(host).wires);
+ mmc_host_disable(host->mmc);
+ if (host->got_dbclk) {
+ clk_disable(host->dbclk);
+ clk_put(host->dbclk);
+ }
+ clk_disable(host->iclk);
+ clk_put(host->iclk);
+ clk_put(host->fclk);
+ goto err1;
+
+ }
if (mmc_slot(host).nonremovable)
mmc->caps |= MMC_CAP_NONREMOVABLE;
--
1.6.3.3
