Felipe Balbi <felipe.balbi@xxxxxxxxx> writes:
> Convert the omap32k clocksource driver into a platform_driver
> and while at that, also remove the ifdeferry around the code.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
This looks mostly good to me. One cosmetic request.
There is some standardized naming happening for devices based on
Benoits work of auto-generating hwmod data. As part of this, this
device will now be called counter_32k instead of '32k sync timer'
since it's just a simple counter and nobody really knew what the 'sync'
was intended to mean. To that end, renaming things to use counter_32k
instead of sync timer would be helpful.
[...]
>
> +static struct resource omap_32k_resources[] = {
> + {
> + .start = -EINVAL, /* gets changed later */
> + .end = -EINVAL, /* gets changed later */
It's more common to just not assign these and leave them as zero.
> + .flags = IORESOURCE_MEM,
> + },
> +};
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
