> -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Thursday, April 01, 2010 5:25 PM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx > Subject: Re: [PATCH 1/2] OMAP3EVM: Made backlight GPIO default state to off > > Hi, > > On Mon, 2010-03-22 at 14:11 +0100, ext hvaibhav@xxxxxx wrote: > > From: Vaibhav Hiremath <hvaibhav@xxxxxx> > > > > If you choose default output to DVI, the LCD backlight still > > gets powered, since panel->disable function never gets called for LCD. > > > > So, during init put backlight GPIO to off state and the driverr > > code will decide which output to enable explicitly. > > I'm not sure I understand this patch. You talk about choosing default > output (via kernel boot args, I presume), [Hiremath, Vaibhav] yes you are correct. I am talking about default output selection using bootargs. > but the code checks for EVM > revision. What is the connection between EVM revision and selecting > display output? [Hiremath, Vaibhav] Ohh ok, I think you are not aware that we do have 2 version of EVM's. EVM-1 with positive (backlight gpio) polarity and EVM-2 with negative (backlight gpio) polarity. The code is doing exactly same. Thanks, Vaibhav > > Tomi > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html