Hi Felipe, On Tue, 30 Mar 2010, Felipe Balbi wrote: > On Tue, Mar 30, 2010 at 10:49:19AM +0200, ext Paul Walmsley wrote: > > I would suggest that you name this function be named something more > > specific, such as omap_sgx_set_bus_tput(), since the SGX driver may also > > need to set other PM constraints later, such as wakeup latency > > constraints. > > then it could just add the contraints to the same function instead of passing > another pointer to driver ?? It's hard to say without looking at the driver. Bus throughput constraints are only needed when the device is actively transferring data to/from the rest of the system. Wakeup latency constraints are only needed when the device can go idle and enter some low-power state, but also needs to be ready in some limited amount of time to service an interrupt or a wakeup. So, often it would make sense to set the two parameters at different points in the driver code. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
