>-----Original Message----- >From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] >Sent: Thursday, March 25, 2010 11:26 PM >To: Guzman Lugo, Fernando >Cc: Kanigeri, Hari; linux-omap@xxxxxxxxxxxxxxx; ameya.palande@xxxxxxxxx; >felipe.contreras@xxxxxxxxx >Subject: Re: PATCH] OMAP3: add mailbox initialization for 3630 > >From: "ext Guzman Lugo, Fernando" <x0095840@xxxxxx> >Subject: RE: PATCH] OMAP3: add mailbox initialization for 3630 >Date: Fri, 26 Mar 2010 00:44:38 +0100 > >> >> >>>-----Original Message----- >>>From: Kanigeri, Hari >>>Sent: Thursday, March 25, 2010 4:56 PM >>>To: Guzman Lugo, Fernando; linux-omap@xxxxxxxxxxxxxxx >>>Cc: Doyu Hiroshi (Nokia-D/Helsinki); Palande Ameya (Nokia-D/Helsinki); >>>Felipe Contreras >>>Subject: RE: PATCH] OMAP3: add mailbox initialization for 3630 >>> >>>Fernando, >>> >>>> + if (cpu_is_omap2420() || cpu_is_omap3430() || >>>> + cpu_is_omap3630() || cpu_is_omap44xx()) >>> >>>looks like this check is applied to all OMAPS. Can we just remove this >>>check ? >> >> There is more defines for more versions like: >> >> cpu_is_omap2422 >> cpu_is_omap3503 >> ... etc, >> >> But I suppose that the mailbox is valid for all of them 24XX, 34XX, 36XX, >44XX. But then why it was only checking for cpu_is_omap2420 or >cpu_is_omap3430 or cpu_is_omap44xx? >> >> Maybe someone knows the reason. Otherwise I agree with you. > >When mailbox driver is introduced for the first time, "dspgateway" >only supported omap2420 since that's the one to have C55x dsp. Now the >type of dsp doesn't matter for mailbox anymore. I think that removing >the this type check would make sense now. Ok, I will send the patch again with the change. Regards, Fernando. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
