> -----Original Message----- > From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] > Sent: Thursday, March 25, 2010 5:08 PM > To: Hebbar, Shivananda > Cc: Menon, Nishanth; linux-omap@xxxxxxxxxxxxxxx; Ramirez Luna, Omar; > Felipe Contreras; Palande Ameya (Nokia-D/Helsinki) > Subject: Re: [RFC][PATCH 0/19] Cleanup- custom error codes > > On Thu, Mar 25, 2010 at 11:37 PM, Hebbar, Shivananda <x0hebbar@xxxxxx> > wrote: > >> love the cleanup *but*: > >> arch/arm/plat-omap/include/dspbridge/dbdefs.h:typedef u32 dsp_status; > >> 1) All usage of dsp_status should be changed to int > > > > Looks like MM code uses this variable. Even MM code needs to be changed > for this. But changes are minimal. > > What do you mean by MM uses this variable? If you mean user-space > (omx, gst-dsp), then no, error codes are passed through ioctl, which > returns an int. Ok ignore my previous comment. TI Multimedia code (lcml) uses DSP_STATUS which is again declared in bridge user side header file. So what Nishanth is referring to can be cleaned up from bridge driver code. Regards, Shivananda -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
