Re: [PATCH v4 1/2] OMAP3: SDRC: Dynamic Calculation of SDRC stall latency during DVFS

[ambresh <a0393775@xxxxxx>]

Sripathy, Vishwanath wrote:
>

> > > +	/* calculate the sram delay */
> > > +	delay_sram = (((mpurate / gt_rate) * diff) / (loop * 2));
> > > +
> > > +	error_gain = mpurate / gt_rate;
> > > +	delay_sram = delay_sram + error_gain;
> > Cosmetic changes:
> >
> >          error_gain = mpurate / gt_rate;
> >          delay_sram = (error_gain * diff) / (loop);
> >          delay_sram += error_gain;
> Why *2 is missing in your code? 2 is needed since the loop takes 2 arm cycles.

its a typo, it should be (loop * 2).

BR,
Ambresh

> Regards
> Vishwa
> > Thanks,
> > Ambresh
> >
> > > +
> > > +	return delay_sram;
> > > +}
> > > +#endif
> > > +
> > >  int __init omap_sram_init(void)
> > >  {
> > >  	omap_detect_sram();
> > >  	omap_map_sram();
> > >
> > > +#ifdef CONFIG_ARCH_OMAP3
> > > +	_omap3_sram_delay = omap_sram_push(__sram_wait_delay,
> > > +						__sram_wait_delay_sz);
> > > +#endif
> > > +
> > >  	if (!(cpu_class_is_omap2()))
> > >  		omap1_sram_init();
> > >  	else if (cpu_is_omap242x())

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html