Re: [PATCH 2/2] DSPBRIDGE: DSP recovery feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 5, 2010 at 12:12 PM, Guzman Lugo, Fernando <x0095840@xxxxxx> wrote:
> --- a/arch/arm/plat-omap/include/dspbridge/drv.h
> +++ b/arch/arm/plat-omap/include/dspbridge/drv.h
> @@ -389,4 +389,7 @@ extern u32 drv_request_resources(u32 dw_context, u32 *pDevNodeString);
>  */
>  extern u32 drv_release_resources(u32 dw_context, struct drv_object *hdrv_obj);
>
> +#ifdef CONFIG_BRIDGE_RECOVERY
> +       void bridge_recover_schedule(void);

The preprocessor macros shouldn't affect indenting AFAIK.

> +#endif
>  #endif /* DRV_ */

> diff --git a/drivers/dsp/bridge/Kconfig b/drivers/dsp/bridge/Kconfig
> index 8d33142..a0cf5f0 100644
> --- a/drivers/dsp/bridge/Kconfig
> +++ b/drivers/dsp/bridge/Kconfig
> @@ -52,6 +52,14 @@ config WDT_TIMEOUT
>           Watchdog timer timeout value, after that time if the watchdog timer
>           counter is not reset the wdt overflow interrupt will be triggered
>
> +config BRIDGE_RECOVERY
> +       bool "DSP Recovery Support"
> +       depends on MPU_BRIDGE
> +       help
> +         In case of DSP fatal error, BRIDGE driver will try to
> +         recover itself.
> +
> +

Extra unnecessary space.

>  comment "Bridge Notifications"
>        depends on MPU_BRIDGE
>

I tried to rebase this patch on top of the latest head and the
user-space client never gets notified of the MMUFAULT. After manually
killing the process, the DSP is restarted correctly though.

Cheers.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux