> -----Original Message----- > From: Hiremath, Vaibhav > Sent: Friday, March 19, 2010 4:45 PM > To: 'tomi.valkeinen@xxxxxxxxx' > Cc: ext Steve Sakoman; linux-omap@xxxxxxxxxxxxxxx > Subject: RE: kernel panic with latest DSS > > > > -----Original Message----- > > From: tomi.valkeinen@xxxxxxxxx [mailto:tomi.valkeinen@xxxxxxxxx] > > Sent: Friday, March 19, 2010 4:41 PM > > To: Hiremath, Vaibhav > > Cc: Valkeinen Tomi (Nokia-D/Helsinki); ext Steve Sakoman; linux- > > omap@xxxxxxxxxxxxxxx > > Subject: RE: kernel panic with latest DSS > > > > > > > > On Fri, 19 Mar 2010, ext Hiremath, Vaibhav wrote: > > > > > > > >> -----Original Message----- > > >> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > > >> owner@xxxxxxxxxxxxxxx] On Behalf Of Tomi Valkeinen > > >> Sent: Friday, March 12, 2010 4:22 PM > > >> To: ext Steve Sakoman > > >> Cc: linux-omap@xxxxxxxxxxxxxxx > > >> Subject: Re: kernel panic with latest DSS > > >> > > >> Can you try this patch? > > >> > > >> I haven't run into this earlier as I always have DSI compiled in. It > > >> possibly doesn't behave correctly in that case either, but doesn't > > >> crash. > > >> > > >> Tomi > > >> > > >> > > >>> From c065bb82e1358105d57d80974ce71d3e5aeabf35 Mon Sep 17 00:00:00 2001 > > >> From: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxx> > > >> Date: Fri, 12 Mar 2010 12:46:05 +0200 > > >> Subject: [PATCH] OMAP: DSS2: initialize dss clk sources properly > > >> > > >> Clk sources were not initialized, leading to kernel crash, or possibly > to > > >> strange behaviour if DSI was compiled in. > > >> > > >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxx> > > >> --- > > >> drivers/video/omap2/dss/dss.c | 3 +++ > > >> 1 files changed, 3 insertions(+), 0 deletions(-) > > >> > > >> diff --git a/drivers/video/omap2/dss/dss.c > > b/drivers/video/omap2/dss/dss.c > > >> index 8254a42..5434418 100644 > > >> --- a/drivers/video/omap2/dss/dss.c > > >> +++ b/drivers/video/omap2/dss/dss.c > > >> @@ -590,6 +590,9 @@ int dss_init(bool skip_init) > > >> } > > >> } > > >> > > >> + dss.dsi_clk_source = DSS_SRC_DSS1_ALWON_FCLK; > > >> + dss.dispc_clk_source = DSS_SRC_DSS1_ALWON_FCLK; > > >> + > > >> dss_save_context(); > > >> > > >> rev = dss_read_reg(DSS_REVISION); > > >> -- > > >> 1.6.5 > > >> > > >> > > > [Hiremath, Vaibhav] Tomi, No this is not helping here, one thing I am > > > not able to understand how does this related to reboot? The crash is > > > happening because the disable is getting called multiple times. So I > > > think the check (added by my patch) is necessary here. > > > > > > Also I am seeing this crash irrespective of DSI enabled or not. > > > > Hmm, reboot? I'm not following. I don't see any patch from you in this > > mail thread. > > > > Are you perhaps talking about some other issue? [Hiremath, Vaibhav] Tomi, Actually, I was referring to following thread, https://patchwork.kernel.org/patch/85201/ Thanks, Vaibhav > [Hiremath, Vaibhav] Opps, Sorry I mixed two issues here. I wanted to reply > to the reboot crash issue and by mistake replied to this thread. > > Thanks, > Vaibhav > > > > > Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
