Hi Kevin, If my understanding is correct. The clk_setuptime is board specific, depends on the osc/XTAL used on the board. So the clk_setuptime has to come from the board file. Volt_setuptime & volt_offset is PM IC specific, depends on the PM IC's SMPS characteristics. So this can be updated from the script file. Finally the voltage cmd values (on, onlp, ret &off) is Si Specific, Varies with Si(OMAP3430, OMAP3630, ...). So can be updated in voltage file itself. Just correct if I'm wrong. Thanks & Regards, Lesly A M -----Original Message----- From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] Sent: Friday, March 19, 2010 5:00 AM To: Lesly A M Cc: linux-omap@xxxxxxxxxxxxxxx; Lesly A M; Nishanth Menon; David Derrick; Samuel Ortiz Subject: Re: [PATCH v3 2/5] omap3: pm: Using separate clk/volt setup_time for RET and OFF states Lesly A M <leslyam@xxxxxx> writes: > Copied the setuptime in each board file, since OMAP3430 & OMAP3630 > has different voltage levels for the same states. So that suggests there should be 2 tables (one per SoC), rather than one for each board file. IOW, the setup times are SoC specific, not board specific, so they don't belong in board files. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html