Re: [PATCHv5 2/2] ASoC: TWL6040: Add twl6040 codec driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16 Mar 2010, at 17:51, "Olaya, Margarita" <magi.olaya@xxxxxx> wrote:

On Saturday, March 13, 2010 5:23 AM  Felipe Balbi wrote:

Hi,

On Fri, 12 Mar 2010 19:52:20 -0600, "Olaya, Margarita"
<magi.olaya@xxxxxx> wrote:
+/*
+ * twl6040 register cache & default register settings + */
+static const u8 twl6040_reg[TWL6040_CACHEREGNUM] = {
+       0x00, /* not used               0x00    */
+       0x4B, /* TWL6040_ASICID (ro)    0x01    */
[snip]

a little comment about what the default values are would be nice.

Most of the codecs only have the register description, not sure if this is an standard in alsa. Some values are kind of hard to describe briefly.

The standard is that these are the power on reset values, used to init the register cache and reduce the amount of I/O done to restore on resume.



#ifdef CONFIG_PM

+static int twl6040_suspend(struct platform_device *pdev,
[snip]

#else
#define twl6040_suspend    NULL
#define twl6040_resume     NULL
#endif

I'll add this.

Regards,
Margarita

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux