* Tony Lindgren <tony@xxxxxxxxxxx> [100315 11:35]: > * Cory Maccarrone <darkstar6262@xxxxxxxxx> [100309 15:38]: > > On Tue, Mar 9, 2010 at 7:56 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > > > > > Does your system boot without any patches if DEBUG_LL is not set > > > in your .config? > > > > No, it doesn't. Seems like the debugging code is still trying to run, > > even disabled. If I add in that check, it'll boot with DEBUG_LL not > > set, but won't without that. > > Sorry for the delay on this. How about with the following patch with > DEBUG_LL not set? > > Note that this is using the shift register now too. Then we may want to do this too for the boards that don't have any UART. Tony
>From b33f67e61cc45558cfbda86b3e2032ffbcb2f99c Mon Sep 17 00:00:00 2001 From: Tony Lindgren <tony@xxxxxxxxxxx> Date: Mon, 15 Mar 2010 10:47:08 -0700 Subject: [PATCH] omap: Fix uncompress code for boards with no UART With the recent DEBUG_LL and uncompress code changes, boards with no UART configured fail to boot as pointed out by Cory Maccarrone <darkstar6262@xxxxxxxxx>. Some boards may not have UARTs available at all, so add DEBUG_LL_NONE option for that. Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> diff --git a/arch/arm/plat-omap/include/plat/uncompress.h b/arch/arm/plat-omap/include/plat/uncompress.h index dc37b2c..7d69d39 100644 --- a/arch/arm/plat-omap/include/plat/uncompress.h +++ b/arch/arm/plat-omap/include/plat/uncompress.h @@ -66,6 +66,13 @@ static inline void flush(void) /* * Macros to configure UART1 and debug UART */ + +#define DEBUG_LL_NONE(mach) \ + if (machine_is_##mach()) { \ + uart_base = 0; \ + break; \ + } + #define _DEBUG_LL_ENTRY(mach, uart1_phys, uart1_shft, \ dbg_uart, dbg_shft, dbg_id) \ if (machine_is_##mach()) { \