On Wed, Mar 10, 2010 at 03:47:08PM +0530, Maulik wrote: > > >Hmm. I must be missing something, but it looks odd to have both the > >USB_MUSB_HDRC and USB_MUSB_SOC high-level config options, especially since > >the depends are duplicated across them. > > >In general, options like these tend to scale badly: > > >config USB_MUSB_SOC > > boolean > > depends on USB_MUSB_HDRC > > default y if ARCH_DAVINCI > > default y if ARCH_OMAP2430 > > default y if ARCH_OMAP34XX > > default y if (BF54x && !BF544) > > default y if (BF52x && !BF522 && !BF523) > > >I.e. every single platform needs to add a new line. It's better > >to have a config option that is selected from the platform code > >(arch/arm/mach-omap2/Kconfig for the specific SOC in this case), that > > Olof, > > I agree with this. Since this change will impact many platforms it will > require thorough testing and review. Can we have OMAP4 MUSB driver support > queued up without this Kconfig enhancement? I believe the driver patches can > go in independent of this enhancement. Yeah, they can go in. It was more a comment in case someone's looking for janitorial things to do. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
