Re: [RFC part1/2 merge v3][PATCH 01/10] OMAP3: serial: Check for zero-based physical addr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Mar 09, 2010 at 10:30:08AM -0600, Aguirre, Sergio wrote:
> Ok, I didn't do that, since there are other printks in the same function.
> 
> I can change it here, no problem.
> 
> I guess I can add a separate patch to standardize and change all
> printks to dev_* macros... would that make sense?

sure that would make more sense :-)

> > change printk() + WARN_ON() into:
> > 
> > WARN(1, "%s: can't init uart%d, no clocks available\n",
> > 	koject_name(&dev->kobj), port);
> 
> That looks nicer. Thanks!

np

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux