* Felipe Balbi <felipe.balbi@xxxxxxxxx> [100304 23:00]: > On Thu, Mar 04, 2010 at 08:15:27PM +0100, ext me@xxxxxxxxxxxxxxx wrote: > >Hi, > > > >On Thu, 4 Mar 2010 18:33:15 +0530, "Gadiyar, Anand" <gadiyar@xxxxxx> > >wrote: > >>>This patch fixes that for the ehci_hdc_omap_platform_data. > >>> > >> > >>should be ehci_hcd_omap_platform_data ;) > >> > >>BTW, this breaks compile for omap3-evm. > >>Could you please build with omap3_defconfig and check. > > > >will do first thing tomorrow :-) > > yeah, it breaks because evm tries to assign to a (now) const > variable. Maybe the only way is to move everybody out of the > __initconst section and put them on __initdata. > > or we drop the revision check for EVM and use only the newer one, > I'm more into doing the first one. > > Tony, do you have any comments ?? Hmm yeah thanks for digging into this mystery. Looks like we're hitting some Linux initdata limitation. We can't mark everything as __initconst. Some platform data can get dynamically set based on the board type for resources. So to me it sounds like the only solution is to mark everything as __initdata and ignore the (correct) const for now for __initdata. Or am I missing something? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
