"Aguirre, Sergio" <saaguirre@xxxxxx> writes: >> -----Original Message----- >> From: Felipe Balbi [mailto:me@xxxxxxxxxxxxxxx] >> Sent: Monday, March 08, 2010 12:25 PM >> To: Aguirre, Sergio >> Cc: linux-omap@xxxxxxxxxxxxxxx; Kevin Hilman; Pandita, Vikram; Paul >> Walmsley; Tony Lindgren >> Subject: Re: [RFC part1/2 merge v2 RESEND][PATCH 01/10] OMAP3: serial: >> Check for zero-based physical addr >> >> On Mon, Mar 08, 2010 at 11:28:43AM -0600, Sergio Aguirre wrote: >> > @@ -727,6 +733,10 @@ void __init omap_serial_init_port(int port) >> > pdev = &uart->pdev; >> > dev = &pdev->dev; >> > >> > + /* Don't proceed if there's no clocks available */ >> > + if (!uart->ick || !uart->fck) >> > + return; >> >> with that loop getting the clocks I would expect this not to happen. If >> it happens, then I would guess it deserves a >> BUG_ON(!uart->ick || !uart->fck) > > Yeah, makes sense. > > Will fix. But please use WARN_ON() check intead of BUG*. Don't need to panic the whole kernel for this. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
