RE: [RFC part1/2 merge][PATCH 06/10] omap3: serial: Fix uart4 handling for 3630

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx]
Sent: Friday, March 05, 2010 4:38 PM

<snip>

> > @@ -694,6 +698,10 @@ void __init omap_serial_early_init(void)
> >
> >  		if (cpu_is_omap44xx())
> >  			p->irq += 32;
> > +
> > +		/* IRQ for UART4 in omap3630 is 80 */
> > +		if (cpu_is_omap3630() && (i == 3))
> > +			p->irq = 80;
> 
> Should add a symbolic name to irqs.h and use it here, instead
> of hard-coded constant.

Sounds like a nice idea! Thanks!

I'll update the patchset and resend.

Regards,
Sergio
> 
> Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux