Re: [PATCH] OMAP: McBSP: Drop unnecessary status/error bit clearing on reg_cache retrieved register values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thursday 04 March 2010 07:49:57 Jarkko Nikula napisał(a):
> On Tue, 23 Feb 2010 16:50:38 +0100
>
> Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> wrote:
> > The MsBSP register cache will never have any error/status flags set,
> > since these flags are never written to the reg_cache. So it is kind of
> > not necessary to clear these flags, which are actually always 0.
> >
> > In other words, clearing the status/error flags are not necessary, since
> > the reg_cache will never got these bits set. We can just write back the
> > register content from the cache as it is when clearing an error
> > condition.
> >
> > Created against l-o for-next commit
> > 62a7c2cc4c8e57e80ccf379536f362fe6e863ac3 dated 2010-02-22.
> > Tested on Amstrad Delta.
> >
> > Reported-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>
> > Signed-off-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx>
>
> Acked-by: Jarkko Nikula <jhnikula@xxxxxxxxx>

Jarkko, thanks.

Tony,
It looks like my initial submission extra comments (quoted discussion with 
Peter) was so confusing, that you had erratically marked this path 
with "changes requested" in your patchowrk, so it get archived. Here is the 
URL, just in case you have troubles finding it now for applying :)
http://patchwork.kernel.org/patch/81476/

Thanks,
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux