Hello Kevin, On Tue, Mar 02, 2010 at 01:11:52AM +0100, ext Kevin Hilman wrote: > Eduardo Valentin <eduardo.valentin@xxxxxxxxx> writes: > > > From: Eduardo Valentin <eduardo.valentin@xxxxxxxxx> > > > > This patch changes the naming convention for OMAP3 cpuidle > > C-states. Currently, depending on which Cstates are enabled/disabled, > > there is a inconsistency between C-state name and what power domain > > states it is supposed to reach when that C-state is selected. > > > > For instance, if all cstates are enabled, "C1" means mpu on and > > core on. But if this exact cstate is disabled, then "C1" doesn't mean > > same power domains state configuration anymore. > > > > So, this patch tries changing the cstates naming convention in order > > to proper and consistently report the cstates names. > > > > Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxx> > > I like this, however... > > Have you considered patching powertop as well? Powertop doesn't seem > to take into consideration the 'desc' field and just names C-states > in increasing order. > > So this patch combined with current powertop acutally makes things > even more confusing. :( Right. I didn't think about powertop in the first place, but you are right. It is worth to have similar changes also on it, to properly use the 'desc' and name fields. I will figure out about it as well. > > Kevin > > > --- > > arch/arm/mach-omap2/cpuidle34xx.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c > > index 50fe9ab..7ab9992 100644 > > --- a/arch/arm/mach-omap2/cpuidle34xx.c > > +++ b/arch/arm/mach-omap2/cpuidle34xx.c > > @@ -367,7 +367,7 @@ int __init omap3_idle_init(void) > > omap3_enter_idle_bm : omap3_enter_idle; > > if (cx->type == OMAP3_STATE_C1) > > dev->safe_state = state; > > - sprintf(state->name, "C%d", count+1); > > + sprintf(state->name, "C%d", cx->type + 1); > > sprintf(state->desc, "MPU=%s NEON=%s CORE=%s", > > pd_states[cx->mpu_state], pd_states[cx->mpu_state], > > pd_states[cx->core_state]); > > -- > > 1.6.5.7.g9ecb2 -- Eduardo Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
